Skip internal logging in compat check #123940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stable API compatibility checks ensure public jars don't change their APIs in incompatible ways. Yet the logging jar has an internal package which can change arbitrarily. This commit adds a temporary workaround to skip the internal logging package until the compat check can be made to look at module-info.
rjernst
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
tvernum
approved these changes
Mar 4, 2025
|
@elasticmachine update branch |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 4, 2025
The stable API compatibility checks ensure public jars don't change their APIs in incompatible ways. Yet the logging jar has an internal package which can change arbitrarily. This commit adds a temporary workaround to skip the internal logging package until the compat check can be made to look at module-info.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 4, 2025
The stable API compatibility checks ensure public jars don't change their APIs in incompatible ways. Yet the logging jar has an internal package which can change arbitrarily. This commit adds a temporary workaround to skip the internal logging package until the compat check can be made to look at module-info.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 4, 2025
The stable API compatibility checks ensure public jars don't change their APIs in incompatible ways. Yet the logging jar has an internal package which can change arbitrarily. This commit adds a temporary workaround to skip the internal logging package until the compat check can be made to look at module-info.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
The stable API compatibility checks ensure public jars don't change their APIs in incompatible ways. Yet the logging jar has an internal package which can change arbitrarily. This commit adds a temporary workaround to skip the internal logging package until the compat check can be made to look at module-info.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
The stable API compatibility checks ensure public jars don't change their APIs in incompatible ways. Yet the logging jar has an internal package which can change arbitrarily. This commit adds a temporary workaround to skip the internal logging package until the compat check can be made to look at module-info.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
The stable API compatibility checks ensure public jars don't change their APIs in incompatible ways. Yet the logging jar has an internal package which can change arbitrarily. This commit adds a temporary workaround to skip the internal logging package until the compat check can be made to look at module-info.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
The stable API compatibility checks ensure public jars don't change their APIs in incompatible ways. Yet the logging jar has an internal package which can change arbitrarily. This commit adds a temporary workaround to skip the internal logging package until the compat check can be made to look at module-info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stable API compatibility checks ensure public jars don't change their APIs in incompatible ways. Yet the logging jar has an internal package which can change arbitrarily. This commit adds a temporary workaround to skip the internal logging package until the compat check can be made to look at module-info.